Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2189283002: Use TranslateManager::GetTargetLanguage() for context menu (Closed)

Created:
4 years, 4 months ago by ftang
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TranslateManager::GetTargetLanguage() for context menu BUG=632545 Committed: https://crrev.com/9939a671897e4500ecb8fa83ec43ca497a8ab161 Cr-Commit-Position: refs/heads/master@{#408587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 4 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ftang
4 years, 4 months ago (2016-07-29 01:37:50 UTC) #2
Avi (use Gerrit)
I don't know the language code specifically, but this looks plausible. LGTM
4 years, 4 months ago (2016-07-29 03:54:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189283002/1
4 years, 4 months ago (2016-07-29 05:59:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 06:02:51 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 06:04:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9939a671897e4500ecb8fa83ec43ca497a8ab161
Cr-Commit-Position: refs/heads/master@{#408587}

Powered by Google App Engine
This is Rietveld 408576698