Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2189253002: DBC: Add single stepping check to fast Smi ops. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Add single stepping check to fast Smi ops. Issue #26405 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/585c476973a176c5db777f6f45bd84c52866b316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-07-29 00:30:45 UTC) #2
zra
lgtm
4 years, 4 months ago (2016-07-29 14:45:57 UTC) #3
rmacnak
4 years, 4 months ago (2016-07-29 17:03:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
585c476973a176c5db777f6f45bd84c52866b316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698