Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2189163002: Add remove non-device-owner user removal confirmation (Closed)

Created:
4 years, 4 months ago by Qiang(Joe) Xu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remove non-device-owner user removal confirmation Just like removing supervised user, there will be a removing warning UI for removing non-device-owner (since device owner doesn't show "Remove this person" entry). The removing warning message right now is just a placeholder. Will update it later once I hear it back from the discussion. BUG=611904 TEST=device test Committed: https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391 Cr-Commit-Position: refs/heads/master@{#408646}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 4 chunks +8 lines, -17 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
Qiang(Joe) Xu
Hi Alex, could you help take a look at it? Thanks!
4 years, 4 months ago (2016-07-28 21:18:52 UTC) #3
Alexander Alekseev
lgtm
4 years, 4 months ago (2016-07-28 21:32:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189163002/1
4 years, 4 months ago (2016-07-28 21:40:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/270996)
4 years, 4 months ago (2016-07-28 22:24:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189163002/20001
4 years, 4 months ago (2016-07-29 04:02:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/227534)
4 years, 4 months ago (2016-07-29 04:08:00 UTC) #17
Qiang(Joe) Xu
Hi xiyuan@, can you help review on the new diff? It is missing owner review. ...
4 years, 4 months ago (2016-07-29 04:25:24 UTC) #19
xiyuan
lgtm
4 years, 4 months ago (2016-07-29 13:34:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189163002/20001
4 years, 4 months ago (2016-07-29 15:59:09 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 16:02:45 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 16:04:28 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391
Cr-Commit-Position: refs/heads/master@{#408646}

Powered by Google App Engine
This is Rietveld 408576698