ui/views/widget/widget_delegate.cc - Issue 2189123002: BubbleFrameView: add padding if platform dislikes close buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_delegate.cc

Issue 2189123002: BubbleFrameView: add padding if platform dislikes close buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: final fixups Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/widget_delegate.cc

diff --git a/ui/views/widget/widget_delegate.cc b/ui/views/widget/widget_delegate.cc

index c5f9d97490c457d01995bd827481638c33a2b275..50dddcac0d63bcd3dc19e43d7d8d85ac0c898a0d 100644

--- a/ui/views/widget/widget_delegate.cc

+++ b/ui/views/widget/widget_delegate.cc

@@ -79,11 +79,7 @@ bool WidgetDelegate::ShouldShowWindowTitle() const {

}

bool WidgetDelegate::ShouldShowCloseButton() const {

-#if defined(OS_MACOSX)

- return false;

-#else

return true;

-#endif

}

bool WidgetDelegate::ShouldHandleSystemCommands() const {

« no previous file with comments | « ui/views/bubble/bubble_frame_view_unittest.cc ('k') | no next file » | no next file with comments »