Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 2189123002: BubbleFrameView: add padding if platform dislikes close buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: final fixups Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_frame_view.cc
diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc
index 43bac842f05e438b5a8001e005c41d2ddc20ddbf..c3714d537673ac730fd818390ec024af2c9aff6f 100644
--- a/ui/views/bubble/bubble_frame_view.cc
+++ b/ui/views/bubble/bubble_frame_view.cc
@@ -211,7 +211,12 @@ void BubbleFrameView::GetWindowMask(const gfx::Size& size,
}
void BubbleFrameView::ResetWindowControls() {
+#if defined(OS_MACOSX)
+ // On Mac, close buttons are never shown.
+ close_->SetVisible(false);
+#else
close_->SetVisible(GetWidget()->widget_delegate()->ShouldShowCloseButton());
+#endif
}
void BubbleFrameView::UpdateWindowIcon() {
@@ -244,7 +249,10 @@ gfx::Insets BubbleFrameView::GetInsets() const {
const bool has_title = icon_height > 0 || label_height > 0;
const int title_padding = has_title ? title_margins_.height() : 0;
const int title_height = std::max(icon_height, label_height) + title_padding;
- const int close_height = close_->visible() ? close_->height() : 0;
+ const int close_height =
+ GetWidget()->widget_delegate()->ShouldShowCloseButton()
+ ? close_->height()
+ : 0;
insets += gfx::Insets(std::max(title_height, close_height), 0, 0, 0);
return insets;
}
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698