Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: base/memory/weak_ptr.cc

Issue 2189113002: Rename CalledOnValidSequencedThread() to CalledOnValidSequence(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/id_map.h ('k') | base/sequence_checker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/weak_ptr.h" 5 #include "base/memory/weak_ptr.h"
6 6
7 namespace base { 7 namespace base {
8 namespace internal { 8 namespace internal {
9 9
10 WeakReference::Flag::Flag() : is_valid_(true) { 10 WeakReference::Flag::Flag() : is_valid_(true) {
11 // Flags only become bound when checked for validity, or invalidated, 11 // Flags only become bound when checked for validity, or invalidated,
12 // so that we can check that later validity/invalidation operations on 12 // so that we can check that later validity/invalidation operations on
13 // the same Flag take place on the same sequenced thread. 13 // the same Flag take place on the same sequenced thread.
14 sequence_checker_.DetachFromSequence(); 14 sequence_checker_.DetachFromSequence();
15 } 15 }
16 16
17 void WeakReference::Flag::Invalidate() { 17 void WeakReference::Flag::Invalidate() {
18 // The flag being invalidated with a single ref implies that there are no 18 // The flag being invalidated with a single ref implies that there are no
19 // weak pointers in existence. Allow deletion on other thread in this case. 19 // weak pointers in existence. Allow deletion on other thread in this case.
20 DCHECK(sequence_checker_.CalledOnValidSequencedThread() || HasOneRef()) 20 DCHECK(sequence_checker_.CalledOnValidSequence() || HasOneRef())
21 << "WeakPtrs must be invalidated on the same sequenced thread."; 21 << "WeakPtrs must be invalidated on the same sequenced thread.";
22 is_valid_ = false; 22 is_valid_ = false;
23 } 23 }
24 24
25 bool WeakReference::Flag::IsValid() const { 25 bool WeakReference::Flag::IsValid() const {
26 DCHECK(sequence_checker_.CalledOnValidSequencedThread()) 26 DCHECK(sequence_checker_.CalledOnValidSequence())
27 << "WeakPtrs must be checked on the same sequenced thread."; 27 << "WeakPtrs must be checked on the same sequenced thread.";
28 return is_valid_; 28 return is_valid_;
29 } 29 }
30 30
31 WeakReference::Flag::~Flag() { 31 WeakReference::Flag::~Flag() {
32 } 32 }
33 33
34 WeakReference::WeakReference() { 34 WeakReference::WeakReference() {
35 } 35 }
36 36
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 } 72 }
73 73
74 WeakPtrBase::~WeakPtrBase() { 74 WeakPtrBase::~WeakPtrBase() {
75 } 75 }
76 76
77 WeakPtrBase::WeakPtrBase(const WeakReference& ref) : ref_(ref) { 77 WeakPtrBase::WeakPtrBase(const WeakReference& ref) : ref_(ref) {
78 } 78 }
79 79
80 } // namespace internal 80 } // namespace internal
81 } // namespace base 81 } // namespace base
OLDNEW
« no previous file with comments | « base/id_map.h ('k') | base/sequence_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698