Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 21891009: Simplify RadioNodeList's anonymous indexed getter (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos
Visibility:
Public.

Description

Simplify RadioNodeList's anonymous indexed getter Make RadioNodeList's anonymous indexed getter argument mandatory and drop the [IsIndex] IDL extended attribute. 'optional' and [IsIndex] have no effect on the generated code of anonymous indexed getters: - There is no way for the caller to omit the index - The generated code uses ObjectTemplate::SetIndexedPropertyHandler() and the IndexedPropertyGetterCallback takes a uint32_t in argument. There is no web-exposed behavior change, the generated bindings code is identical. R=haraken BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/RadioNodeList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-05 13:37:38 UTC) #1
haraken
LGTM
7 years, 4 months ago (2013-08-05 13:53:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21891009/1
7 years, 4 months ago (2013-08-05 14:05:27 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-05 14:34:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21891009/1
7 years, 4 months ago (2013-08-05 16:30:55 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-05 18:59:09 UTC) #6
Message was sent while issue was closed.
Change committed as 155535

Powered by Google App Engine
This is Rietveld 408576698