Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2189093002: fix text matrix again (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

fix text matrix again The text matrix for Skia is still wrong. The last fix allowed text to draw correctly when rotated, but did not draw correctly when skewed. With this edit, text draws correctly rotated, skewed horizontally, skewed vertically, and rotated and skewed. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0600234fc65d52e4830ad2cc6c1723fb33c9414f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
caryclark
4 years, 4 months ago (2016-07-28 18:19:53 UTC) #1
dsinclair
lgtm
4 years, 4 months ago (2016-07-28 18:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189093002/1
4 years, 4 months ago (2016-07-28 18:23:09 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 18:35:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0600234fc65d52e4830ad2cc6c1723fb33c9...

Powered by Google App Engine
This is Rietveld 408576698