Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Issue 2189073003: Add configuration_changed event and set_background_opacity request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated interface comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
diff --git a/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml b/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
index 02d588f042e92dee68cfb2e11a6de7802833d869..552fbe2fbd1af36c5883a6bbcd0d160fa3c32730 100644
--- a/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
+++ b/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
@@ -38,7 +38,7 @@
reset.
</description>
- <interface name="zwp_remote_shell_v1" version="8">
+ <interface name="zwp_remote_shell_v1" version="9">
<description summary="remote_shell">
The global interface that allows clients to turn a wl_surface into a
"real window" which is remotely managed but can be stacked, activated
@@ -107,7 +107,7 @@
<event name="configure">
<description summary="suggests a re-layout of remote shell">
- Suggests a re-layout of remote surface geometry.
+ Obsolete: Suggests a re-layout of remote surface geometry.
</description>
<arg name="width" type="int"/>
<arg name="height" type="int"/>
@@ -141,16 +141,42 @@
<event name="layout_mode_changed" since="8">
<description summary="layout mode changed">
- The shell_mode_changed event is sent by the compositor when
+ Obsolete: The shell_mode_changed event is sent by the compositor when
the shell mode was changed.
This is an event to notify that the shell mode has switched.
</description>
<arg name="layout_mode" type="uint"/>
</event>
+
+ <!-- Version 9 additions -->
+
+ <event name="display_changed" since="9">
reveman 2016/07/28 19:52:02 nit: we don't really have a "display" concept in a
oshima 2016/07/28 22:49:48 done.
+ <description summary="suggests a re-configuration of display for remote shell">
reveman 2016/07/28 19:52:02 nit: s/of display for remote shell/of remote shell
oshima 2016/07/28 22:49:48 Done.
+ Suggests a re-configuration of display for remote shell.
reveman 2016/07/28 19:52:01 nit: ditto
oshima 2016/07/28 22:49:48 Done.
+ </description>
+ <arg name="output_origin_x" type="int"/>
+ <arg name="output_origin_y" type="int"/>
reveman 2016/07/28 19:52:02 nit: origin_x/y btw, what's this used for? do we
oshima 2016/07/28 22:49:48 Removed.
+ <arg name="output_width_mm" type="int"/>
+ <arg name="output_height_mm" type="int"/>
reveman 2016/07/28 19:52:02 nit: width/height_mm
oshima 2016/07/28 22:49:48 Done.
+ <arg name="output_subpixel_layout" type="int"/>
reveman 2016/07/28 19:52:02 nit: subpixel_layout, do we really need this?
oshima 2016/07/28 22:49:48 Removed. We may need it in the future for proper f
+ <arg name="output_transform" type="int"/>
reveman 2016/07/28 19:52:02 nit: name="transform"
oshima 2016/07/28 22:49:48 Done.
+
+ <arg name="output_mode_width_pixels" type="int"/>
+ <arg name="output_mode_height_pixels" type="int"/>
reveman 2016/07/28 19:52:02 do we need these? is display_width/height below no
oshima 2016/07/28 22:49:48 They're both used (for physical size and logical p
+ <arg name="output_mode_refresh_rate_mhz" type="int"/>
reveman 2016/07/28 19:52:01 please remove if not needed
oshima 2016/07/28 22:49:48 It looks to me this is used. (it's passed to hwc)
+ <arg name="display_scale_factor" type="fixed"/>
reveman 2016/07/28 19:52:02 nit: name="scale_factor"
+ <arg name="display_width" type="int"/>
+ <arg name="display_height" type="int"/>
reveman 2016/07/28 19:52:02 nit: name="width"/"height"
oshima 2016/07/28 22:49:48 done.
+ <arg name="work_area_inset_left" type="int"/>
+ <arg name="work_area_inset_top" type="int"/>
+ <arg name="work_area_inset_right" type="int"/>
+ <arg name="work_area_inset_bottom" type="int"/>
+ <arg name="layout_mode" type="uint"/>
+ </event>
</interface>
- <interface name="zwp_remote_surface_v1" version="8">
+ <interface name="zwp_remote_surface_v1" version="9">
<description summary="A desktop window">
An interface that may be implemented by a wl_surface, for
implementations that provide a desktop-style user interface
@@ -469,6 +495,16 @@
Suggests a surface should become non system modal.
</description>
</request>
+
+ <!-- Version 9 additions -->
+
+ <request name="set_background_opacity" since="9">
reveman 2016/07/28 19:52:02 nit: set_rectangular_shadow_background_opacity as
oshima 2016/07/28 22:49:48 I'd just change the background for now. We can adj
+ <description summary="suggests the window's background opacity">
+ Suggests the window's background opacity.
+ </description>
+ <arg name="opacity" type="fixed"/>
+ </request>
+
</interface>
<!-- Version 6 additions -->

Powered by Google App Engine
This is Rietveld 408576698