Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2189033002: [heap] Do not allow left trimming on new space pages that need to be swept. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not allow left trimming on new space pages that need to be swept. BUG=chromium:630969, chromium:632334 LOG=n Committed: https://crrev.com/76812cc75c7cced77a828eb65351a8b9fb1a7e3f Cr-Commit-Position: refs/heads/master@{#38137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Lippautz
\o/ lgtm \o/
4 years, 4 months ago (2016-07-28 13:15:24 UTC) #2
Hannes Payer (out of office)
4 years, 4 months ago (2016-07-28 13:15:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189033002/1
4 years, 4 months ago (2016-07-28 13:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189033002/1
4 years, 4 months ago (2016-07-28 13:33:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 13:48:14 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 13:50:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76812cc75c7cced77a828eb65351a8b9fb1a7e3f
Cr-Commit-Position: refs/heads/master@{#38137}

Powered by Google App Engine
This is Rietveld 408576698