Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2189023002: [inspector] add test configuration for the parser test. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] add test configuration for the parser test. BUG=chromium:580337 R=machenbach@chromium.org Committed: https://crrev.com/5d49286c696d78b42227732347ff5f23ed2fc83b Cr-Commit-Position: refs/heads/master@{#38198}

Patch Set 1 #

Total comments: 5

Patch Set 2 : change test status to skip #

Patch Set 3 : address comments #

Patch Set 4 : include v8.gyp for variables #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : update DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M test/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M test/bot_default.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/bot_default.isolate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/default.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/default.isolate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A + test/inspector_protocol_parser_test/inspector_protocol_parser_test.isolate View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/inspector_protocol_parser_test/inspector_protocol_parser_test.status View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Yang
4 years, 4 months ago (2016-07-28 12:45:01 UTC) #1
Michael Achenbach
https://codereview.chromium.org/2189023002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2189023002/diff/1/tools/run-tests.py#newcode64 tools/run-tests.py:64: # This needs to stay in sync with test/bot_default.isolate. ...
4 years, 4 months ago (2016-07-28 13:03:18 UTC) #2
Yang
https://codereview.chromium.org/2189023002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/2189023002/diff/1/tools/run-tests.py#newcode64 tools/run-tests.py:64: # This needs to stay in sync with test/bot_default.isolate. ...
4 years, 4 months ago (2016-07-28 13:36:44 UTC) #3
Michael Achenbach
LGTM. Would be worth looking at the trybot test step output and checking if the ...
4 years, 4 months ago (2016-07-28 14:03:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189023002/120001
4 years, 4 months ago (2016-08-01 09:44:54 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 4 months ago (2016-08-01 09:48:55 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 09:50:22 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/5d49286c696d78b42227732347ff5f23ed2fc83b
Cr-Commit-Position: refs/heads/master@{#38198}

Powered by Google App Engine
This is Rietveld 408576698