Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2188993004: Remove AnimationTimeline pre-finalizer (Closed)

Created:
4 years, 4 months ago by alancutter (OOO until 2018)
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@_fixAnimationPoisonCrash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AnimationTimeline pre-finalizer Now that Animations have their own pre-finalizers to clean up their CompositorAnimationPlayers there's no need for AnimationTimeline to dispose of them. Committed: https://crrev.com/c9a6c9eca777a42d2341e9ebba19449811968353 Cr-Commit-Position: refs/heads/master@{#408574}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 2 chunks +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
alancutter (OOO until 2018)
Changes to AnimationTimeline as discussed in https://codereview.chromium.org/2188623006.
4 years, 4 months ago (2016-07-28 12:47:22 UTC) #2
haraken
LGTM Thanks for a lot of iterations!
4 years, 4 months ago (2016-07-28 12:48:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188993004/20001
4 years, 4 months ago (2016-07-29 02:58:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 04:16:35 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 04:19:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9a6c9eca777a42d2341e9ebba19449811968353
Cr-Commit-Position: refs/heads/master@{#408574}

Powered by Google App Engine
This is Rietveld 408576698