src/interpreter/interpreter-assembler.cc - Issue 2188993003: [stubs] Port CreateWeakCellStub to turbofan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/interpreter-assembler.cc

Issue 2188993003: [stubs] Port CreateWeakCellStub to turbofan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix stack overflow Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/interpreter-assembler.cc

diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc

index dc5f9afbba02ff7d562f51a6c7bb8a614301bbb2..03d7a542be148b424bfaa560091212edd30b2658 100644

--- a/src/interpreter/interpreter-assembler.cc

+++ b/src/interpreter/interpreter-assembler.cc

@@ -548,10 +548,8 @@ Node* InterpreterAssembler::CallJSWithFeedback(Node* function, Node* context,

StoreFixedArrayElement(type_feedback_vector, call_count_slot,

SmiTag(Int32Constant(1)), SKIP_WRITE_BARRIER);

- CreateWeakCellStub weak_cell_stub(isolate());

- CallStub(weak_cell_stub.GetCallInterfaceDescriptor(),

- HeapConstant(weak_cell_stub.GetCode()), context,

- type_feedback_vector, SmiTag(slot_id), function);

+ CreateWeakCellInFeedbackVector(type_feedback_vector, SmiTag(slot_id),

Benedikt Meurer 2016/07/28 10:30:45 Awesome!

+ function);

// Call using call function builtin.

Callable callable = CodeFactory::InterpreterPushArgsAndCall(

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »