Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 2188993003: [stubs] Port CreateWeakCellStub to turbofan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix stack overflow Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 19cdfb7d5c79e32e72948b625fc561a1ab22b8d8..02d88e4c3f49b7152f0ea34a02964718c28da7b5 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -542,37 +542,6 @@ Handle<Code> FastCloneShallowArrayStub::GenerateCode() {
return DoGenerateCode(this);
}
-
-template <>
-HValue* CodeStubGraphBuilder<CreateWeakCellStub>::BuildCodeStub() {
- // This stub is performance sensitive, the generated code must be tuned
- // so that it doesn't build an eager frame.
- info()->MarkMustNotHaveEagerFrame();
-
- HValue* size = Add<HConstant>(WeakCell::kSize);
- HInstruction* object =
- Add<HAllocate>(size, HType::JSObject(), TENURED, JS_OBJECT_TYPE,
- graph()->GetConstant0());
-
- Handle<Map> weak_cell_map = isolate()->factory()->weak_cell_map();
- AddStoreMapConstant(object, weak_cell_map);
-
- HInstruction* value = GetParameter(Descriptor::kValue);
- Add<HStoreNamedField>(object, HObjectAccess::ForWeakCellValue(), value);
- Add<HStoreNamedField>(object, HObjectAccess::ForWeakCellNext(),
- graph()->GetConstantHole());
-
- HInstruction* feedback_vector = GetParameter(Descriptor::kVector);
- HInstruction* slot = GetParameter(Descriptor::kSlot);
- Add<HStoreKeyed>(feedback_vector, slot, object, nullptr, FAST_ELEMENTS,
- INITIALIZING_STORE);
- return graph()->GetConstant0();
-}
-
-
-Handle<Code> CreateWeakCellStub::GenerateCode() { return DoGenerateCode(this); }
-
-
template <>
HValue* CodeStubGraphBuilder<LoadScriptContextFieldStub>::BuildCodeStub() {
int context_index = casted_stub()->context_index();

Powered by Google App Engine
This is Rietveld 408576698