Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2188993003: [stubs] Port CreateWeakCellStub to turbofan (Closed)

Created:
4 years, 4 months ago by danno
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port CreateWeakCellStub to turbofan In the process also inline the stub into the appropriate interpreter bytecode handler and make sure that the context register is preserved in hand-written assembly code that calls the stub and expects the context register to be preserved. BUG=608675 Committed: https://crrev.com/7f1fa30e3437d38ab7c949c19659f52e8233fba9 Cr-Commit-Position: refs/heads/master@{#38132}

Patch Set 1 #

Patch Set 2 : x64 works #

Patch Set 3 : All platforms #

Patch Set 4 : Fix Mips #

Patch Set 5 : Fix stack overflow #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -63 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M src/code-stubs.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/code-stubs.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 1 chunk +2 lines, -4 lines 1 comment Download
M src/mips/code-stubs-mips.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-353551.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (19 generated)
danno
ptal
4 years, 4 months ago (2016-07-28 09:58:08 UTC) #11
Benedikt Meurer
Nice, LGTM. https://codereview.chromium.org/2188993003/diff/70001/src/interpreter/interpreter-assembler.cc File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2188993003/diff/70001/src/interpreter/interpreter-assembler.cc#newcode551 src/interpreter/interpreter-assembler.cc:551: CreateWeakCellInFeedbackVector(type_feedback_vector, SmiTag(slot_id), Awesome!
4 years, 4 months ago (2016-07-28 10:30:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188993003/70001
4 years, 4 months ago (2016-07-28 11:44:23 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 4 months ago (2016-07-28 11:45:42 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 11:49:06 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7f1fa30e3437d38ab7c949c19659f52e8233fba9
Cr-Commit-Position: refs/heads/master@{#38132}

Powered by Google App Engine
This is Rietveld 408576698