ResizeObserver pt5: size change notification

third_party/WebKit/Source/core/observer/ResizeObserver.h

Index: third_party/WebKit/Source/core/observer/ResizeObserver.h
diff --git a/third_party/WebKit/Source/core/observer/ResizeObserver.h b/third_party/WebKit/Source/core/observer/ResizeObserver.h
index 9bdde3841e47ffa89b86f414f7555bea35ad0e57..85e1c28e0a099da5a8ec189a61b49e2e6df264fc 100644
--- a/third_party/WebKit/Source/core/observer/ResizeObserver.h
+++ b/third_party/WebKit/Source/core/observer/ResizeObserver.h
@@ -14,6 +14,7 @@ class Document;
 class Element;
 class ResizeObserverCallback;
 class ResizeObserverController;
+class ResizeObserverEntry;
 class ResizeObservation;
 
 // ResizeObserver represents ResizeObserver javascript api:
@@ -21,7 +22,6 @@ class ResizeObservation;
 class CORE_EXPORT ResizeObserver final : public GarbageCollectedFinalized<ResizeObserver>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
-
     static ResizeObserver* create(Document&, ResizeObserverCallback*);
 
     virtual ~ResizeObserver() {};
@@ -31,23 +31,32 @@ public:
     void unobserve(Element*);
     void disconnect();
 
+    // Returns depth of shallowest observed node, kDepthLimit if none.
+    size_t gatherObservations(size_t deeperThan);
+    bool skippedObservations() { return m_skippedObservations; }

[ikilpatrick, 2016/07/28 21:48:40]

skippedObservations isn't immediately clear what it does / used for, comment.

[atotic1, 2016/07/29 20:04:16]

Will create a comment in ResizeObserverController.h, where this API is
documented.

Done.

+    void deliverObservations();
+    void clearObservations();
+    void elementSizeChanged();
+    bool hasElementSizeChanged() { return m_elementSizeChanged; }
     DECLARE_TRACE();
 
 private:
-
-    using ObservationList = HeapLinkedHashSet<WeakMember<ResizeObservation>>;
-
     explicit ResizeObserver(ResizeObserverCallback*, Document&);

[ikilpatrick, 2016/07/28 21:48:40]

explicit isn't needed?

[atotic1, 2016/07/29 20:04:16]

Done.

[ikilpatrick, 2016/07/29 23:18:38]

Not done yet?

[atotic1, 2016/07/30 03:16:29]

Done. Did not check in changes while waiting on targetDepth discussion.

 
+    using ObservationList = HeapLinkedHashSet<WeakMember<ResizeObservation>>;
+
     Member<ResizeObserverCallback> m_callback;
-
     // List of elements we are observing
     ObservationList m_observations;
-
+    // List of elements that have changes
+    HeapVector<Member<ResizeObservation>> m_activeObservations;
+    // True if observations were skipped gatherObservations
+    bool m_skippedObservations;
+    // True if any ResizeObservation reported size change
+    bool m_elementSizeChanged;
     WeakMember<ResizeObserverController> m_controller;
 };
 
-
 } // namespace blink
 
 #endif // ResizeObserver_h