Uninline RuntimeCallStatEntries::Add to save binary size.

Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
Committed: https://crrev.com/a79ec0e3a9667cb142419b1ae5921c72212bcf31
Cr-Commit-Position: refs/heads/master@{#38182}

[dcheng, 2016-07-28 07:35:25]

Description was changed from

==========
Uninline RuntimeCallStatEntries::Add.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
==========

to

==========
Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
==========

[dcheng, 2016-07-28 07:35:25]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2016-07-28 08:07:19]

The optimizer appears to be somewhat non-deterministic in what it decides to
inline. A similar issue in v8::internal::ObjectStats::PrintJSON only shows up in
release builds, not official builds:
https://bugs.chromium.org/p/v8/issues/detail?id=5241

But this reliably shows up in both.

[jochen (gone - plz use gerrit), 2016-07-29 14:41:31]

jochen@chromium.org changed reviewers:
+ cbruni@chromium.org

[jochen (gone - plz use gerrit), 2016-07-29 14:41:31]

+cbruni

will that negatively impact performance?

[Camillo Bruni, 2016-07-29 14:48:47]

LGTM this is purely used when printing, so not performance critical

[dcheng, 2016-07-29 15:06:48]

I tweaked the comment slightly to make it clearer where the increase in binary
size mostly comes from.

[dcheng, 2016-07-29 15:06:58]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-07-29 15:06:58]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2188953003/#ps20001
(title: "Comment clarification")

[commit-bot: I haz the power, 2016-07-29 15:07:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:29:23]

Description was changed from

==========
Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
==========

to

==========
Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
==========

[commit-bot: I haz the power, 2016-07-29 15:29:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 15:30:52]

Description was changed from

==========
Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240
==========

to

==========
Uninline RuntimeCallStatEntries::Add to save binary size.

RuntimeCallStats::Print invokes this function many times. The uses of
STL all get inlined as a result, causing the Print() function to take up
156KB of binary size. Out-of-lining this method reduces the size to
under 18KB!

BUG=v8:5240

Committed: https://crrev.com/a79ec0e3a9667cb142419b1ae5921c72212bcf31
Cr-Commit-Position: refs/heads/master@{#38182}
==========

[commit-bot: I haz the power, 2016-07-29 15:30:53]

Patchset 2 (id:??) landed as
https://crrev.com/a79ec0e3a9667cb142419b1ae5921c72212bcf31
Cr-Commit-Position: refs/heads/master@{#38182}