Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: content/renderer/android/synchronous_compositor_output_surface.cc

Issue 2188943002: Remove OutputSurfaceClient external clip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unittests compile Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/android/synchronous_compositor_output_surface.cc
diff --git a/content/renderer/android/synchronous_compositor_output_surface.cc b/content/renderer/android/synchronous_compositor_output_surface.cc
index 10b0ecae94577c284fc2b32fa3850a1b0039e39e..db6964e5684c8ec046291ac4957020453cd643ad 100644
--- a/content/renderer/android/synchronous_compositor_output_surface.cc
+++ b/content/renderer/android/synchronous_compositor_output_surface.cc
@@ -302,10 +302,7 @@ uint32_t SynchronousCompositorOutputSurface::GetFramebufferCopyTextureFormat() {
}
void SynchronousCompositorOutputSurface::DemandDrawHw(
- const gfx::Size& surface_size,
- const gfx::Transform& transform,
const gfx::Rect& viewport,
- const gfx::Rect& clip,
const gfx::Rect& viewport_rect_for_tile_priority,
const gfx::Transform& transform_for_tile_priority) {
DCHECK(CalledOnValidThread());
@@ -315,7 +312,7 @@ void SynchronousCompositorOutputSurface::DemandDrawHw(
client_->SetExternalTilePriorityConstraints(viewport_rect_for_tile_priority,
transform_for_tile_priority);
- InvokeComposite(transform, viewport, clip);
+ InvokeComposite(gfx::Transform(), viewport);
}
void SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas* canvas) {
@@ -328,27 +325,26 @@ void SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas* canvas) {
SkIRect canvas_clip;
canvas->getClipDeviceBounds(&canvas_clip);
- gfx::Rect clip = gfx::SkIRectToRect(canvas_clip);
+ gfx::Rect viewport = gfx::SkIRectToRect(canvas_clip);
gfx::Transform transform(gfx::Transform::kSkipInitialization);
transform.matrix() = canvas->getTotalMatrix(); // Converts 3x3 matrix to 4x4.
base::AutoReset<bool> set_in_software_draw(&in_software_draw_, true);
- display_->SetExternalViewport(clip);
- display_->SetExternalClip(clip);
+ display_->SetExternalViewport(viewport);
+ display_->SetExternalClip(viewport);
software_output_surface_->SetSurfaceSize(
gfx::SkISizeToSize(canvas->getBaseLayerSize()));
- InvokeComposite(transform, clip, clip);
+ InvokeComposite(transform, viewport);
}
void SynchronousCompositorOutputSurface::InvokeComposite(
const gfx::Transform& transform,
- const gfx::Rect& viewport,
- const gfx::Rect& clip) {
+ const gfx::Rect& viewport) {
gfx::Transform adjusted_transform = transform;
adjusted_transform.matrix().postTranslate(-viewport.x(), -viewport.y(), 0);
did_swap_ = false;
- client_->OnDraw(adjusted_transform, viewport, clip, in_software_draw_);
+ client_->OnDraw(adjusted_transform, viewport, in_software_draw_);
if (did_swap_) {
// This must happen after unwinding the stack and leaving the compositor.

Powered by Google App Engine
This is Rietveld 408576698