Remove OutputSurfaceClient external clip

Remove OutputSurfaceClient external clip

All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.

Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.

BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/31c233edb6fe41936b7b68c873e4f4368a38179a
Cr-Commit-Position: refs/heads/master@{#408580}

[boliu, 2016-07-28 01:38:18]

Description was changed from

==========
Remove OutputSurfaceClient external clip

All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.

Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.

BUG=631276
==========

to

==========
Remove OutputSurfaceClient external clip

All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.

Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.

BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[boliu, 2016-07-28 16:38:42]

boliu@chromium.org changed reviewers:
+ danakj@chromium.org

[boliu, 2016-07-28 16:38:43]

ptal

[danakj, 2016-07-28 20:59:30]

LGTM

https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1671: DeviceViewport(), DeviceViewport());
Can we just not pass it to renderer too?

[boliu, 2016-07-28 21:10:11]

https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1671: DeviceViewport(), DeviceViewport());
On 2016/07/28 20:59:30, danakj wrote:
> Can we just not pass it to renderer too?

cc::Display in hardware_renderer in webview still passes different viewport and
clip, so not right now.

So one more clean up after DirectRenderer isn't part of compositor anymore?

[danakj, 2016-07-28 21:11:36]

On Thu, Jul 28, 2016 at 2:10 PM, <boliu@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
> File cc/trees/layer_tree_host_impl.cc (right):
>
>
>
https://codereview.chromium.org/2188943002/diff/20001/cc/trees/layer_tree_hos...
> cc/trees/layer_tree_host_impl.cc:1671: DeviceViewport(),
> DeviceViewport());
> On 2016/07/28 20:59:30, danakj wrote:
> > Can we just not pass it to renderer too?
>
> cc::Display in hardware_renderer in webview still passes different
> viewport and clip, so not right now.
>
> So one more clean up after DirectRenderer isn't part of compositor
> anymore?
>

Ah okay.


>
> https://codereview.chromium.org/2188943002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[boliu, 2016-07-28 21:41:56]

boliu@chromium.org changed reviewers:
+ creis@chromium.org, dcheng@chromium.org

[boliu, 2016-07-28 21:41:57]

+dcheng for ipc

+creis to stamp content/public? sievers is swamped, and I own everything else in
content already

[Charlie Reis, 2016-07-28 22:24:43]

RS LGTM for content/.

[dcheng, 2016-07-29 04:03:34]

lgtm

[boliu, 2016-07-29 04:04:48]

The CQ bit was checked by boliu@chromium.org

[boliu, 2016-07-29 04:04:48]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2188943002/#ps40001
(title: "viewport -> viewport_size")

[commit-bot: I haz the power, 2016-07-29 04:05:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 05:39:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-29 05:40:55]

Description was changed from

==========
Remove OutputSurfaceClient external clip

All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.

Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.

BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove OutputSurfaceClient external clip

All use cases of OutputSurfaceClient::OnDraw pass the exact same value
for external viewport and clip, so remove the redundancy.

Also take this opporunity to clean up the sync compositor hardware draw
IPC. A bunch of params are no longer needed.

BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/31c233edb6fe41936b7b68c873e4f4368a38179a
Cr-Commit-Position: refs/heads/master@{#408580}
==========

[commit-bot: I haz the power, 2016-07-29 05:40:56]

Patchset 3 (id:??) landed as
https://crrev.com/31c233edb6fe41936b7b68c873e4f4368a38179a
Cr-Commit-Position: refs/heads/master@{#408580}