Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 218893002: Merge 255276 "RendererWebColorChooserImpl shouldn't be destroyed..." (Closed)

Created:
6 years, 8 months ago by keishi
Modified:
6 years, 8 months ago
Reviewers:
keishi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 255276 "RendererWebColorChooserImpl shouldn't be destroyed..." > RendererWebColorChooserImpl shouldn't be destroyed by RenderViewObserver::OnDestruct > > RenderWebColorChooserImpl is owned by blink::ColorChooserUIController so it should not be destroyed in RenderViewObserver::OnDestruct > > BUG=342735 > > Review URL: https://codereview.chromium.org/181233006 TBR=keishi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/renderer/renderer_webcolorchooser_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
keishi
6 years, 8 months ago (2014-03-31 02:15:54 UTC) #1
keishi
6 years, 8 months ago (2014-03-31 02:17:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r260483.

Powered by Google App Engine
This is Rietveld 408576698