Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2188893003: Change the expected results on win10 bots (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the expected results on win10 bots Right now fast/images/paint-subrect-grid.html fails on win10. By looking at the expected results directory, I found that win7 doesn't have expected.png for this test, which means it refers to the expected.png under win/ directory. By looking at the stdio of win7 bots, it appears that this test always pass at the first run. That means the expected.png is good for win7, but not good for win10. So in this CL, we copy the expected.png from win/ to win7/. And replace the expected.png under win/ by the actual results generated from the win10 bots. So that next time when win10 bots runs, it will refer to the actual result that itself generated, which should pass. We should closely monitor win7 and win10 bots to make sure that they are green after this change. TBR=schenney@chromium.org BUG=632000 Committed: https://crrev.com/fe248e2d21e6c1852584c47e628e6b8664cc7faf Cr-Commit-Position: refs/heads/master@{#408450}

Patch Set 1 #

Patch Set 2 : add a blank line in a source file to trigger bots to run #

Patch Set 3 : PS2 proves that this CL should work, so back to PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/images/paint-subrect-grid-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/fast/images/paint-subrect-grid-expected.png View Binary file 0 comments Download

Messages

Total messages: 12 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188893003/40001
4 years, 4 months ago (2016-07-28 19:09:13 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 19:14:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 19:17:51 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe248e2d21e6c1852584c47e628e6b8664cc7faf
Cr-Commit-Position: refs/heads/master@{#408450}

Powered by Google App Engine
This is Rietveld 408576698