Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218883013: Mojo: Move public/bindings/tests/*.cc to public/cpp/bindings/tests/. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move public/bindings/tests/*.cc to public/cpp/bindings/tests/. I have to figure out where the .mojom files should go (since they're also used by the JS bindings tests), probably somewhere under public/interfaces/ (but where?). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1888 lines) Patch
M mojo/mojo_public.gypi View 1 chunk +9 lines, -9 lines 0 comments Download
D mojo/public/bindings/tests/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/bindings/tests/array_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/public/bindings/tests/buffer_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D mojo/public/bindings/tests/connector_unittest.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D mojo/public/bindings/tests/handle_passing_unittest.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D mojo/public/bindings/tests/remote_ptr_unittest.cc View 1 chunk +0 lines, -230 lines 0 comments Download
D mojo/public/bindings/tests/request_response_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D mojo/public/bindings/tests/router_unittest.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D mojo/public/bindings/tests/sample_service_unittest.cc View 1 chunk +0 lines, -355 lines 0 comments Download
D mojo/public/bindings/tests/type_conversion_unittest.cc View 1 chunk +0 lines, -236 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/bindings/tests/array_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/buffer_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/connector_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/remote_ptr_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/request_response_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/router_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-01 16:52:34 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-01 19:19:40 UTC) #2
viettrungluu
6 years, 8 months ago (2014-04-01 20:20:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r260935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698