Fix another inappropriate overscroll glow.

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/basictypes.h"
@@ skipping 2246 matching lines @@
     bool did_move_layer_x = std::abs(applied_delta.x()) > move_threshold;
     bool did_move_layer_y = std::abs(applied_delta.y()) > move_threshold;
     did_scroll_x |= did_move_layer_x;
     did_scroll_y |= did_move_layer_y;
     if (!did_move_layer_x && !did_move_layer_y) {
       // Scrolls should always bubble between the outer and inner viewports
       if (should_bubble_scrolls_ || !did_lock_scrolling_layer_ ||
           layer_impl == OuterViewportScrollLayer())
         continue;
       else
         break;

[aelias_OOO_until_Jul13, 2014/04/01 02:28:20]

Hmm, even with your latest changes, I notice another bug that there is a small
overscroll glow at the end of flings (when they slow down completely).

I believe the bug is simply that this "break" here sometimes prevents the
subtraction from happening at all.  Could you move up the
unused_root_delta.Subtract clause right above "If the layer wasn't able to move"
comment?  Then remove the other changes in this patch.

     }
 
     if (layer_impl == InnerViewportScrollLayer()) {
       unused_root_delta.Subtract(applied_delta);
-      const float kOverscrollEpsilon = 0.01f;
+      const float kOverscrollEpsilon = move_threshold;
       if (std::abs(unused_root_delta.x()) < kOverscrollEpsilon)
         unused_root_delta.set_x(0.0f);
       if (std::abs(unused_root_delta.y()) < kOverscrollEpsilon)
         unused_root_delta.set_y(0.0f);
     }
 
     did_lock_scrolling_layer_ = true;
     if (!should_bubble_scrolls_) {
       active_tree_->SetCurrentlyScrollingLayer(layer_impl);
       break;
@@ skipping 25 matching lines @@
     client_->RenewTreePriority();
   }
 
   // Scrolling along an axis resets accumulated root overscroll for that axis.
   if (did_scroll_x)
     accumulated_root_overscroll_.set_x(0);
   if (did_scroll_y)
     accumulated_root_overscroll_.set_y(0);
 
   accumulated_root_overscroll_ += unused_root_delta;
-  bool did_overscroll = !unused_root_delta.IsZero();
+  bool did_overscroll =
+      !unused_root_delta.IsZero() && !(did_scroll_x && did_scroll_y);
   if (did_overscroll && input_handler_client_) {
     DidOverscrollParams params;
     params.accumulated_overscroll = accumulated_root_overscroll_;
     params.latest_overscroll_delta = unused_root_delta;
     params.current_fling_velocity = current_fling_velocity_;
     input_handler_client_->DidOverscroll(params);
   }
 
   return did_scroll_content || did_scroll_top_controls;
 }
@@ skipping 690 matching lines @@
   swap_promise_monitor_.erase(monitor);
 }
 
 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
   std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
   for (; it != swap_promise_monitor_.end(); it++)
     (*it)->OnSetNeedsRedrawOnImpl();
 }
 
 }  // namespace cc