Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2188813003: content: Remove views dependency. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, tfarina, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus-public-cpp-component
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Remove views dependency. Lookup the ui::Window associated with an AcceleratedWidget from ui::ViewProp, instead of going through aura and views. This allows removing the dependency on views from content. BUG=none

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M services/ui/public/cpp/lib/window.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (9 generated)
sadrul
4 years, 4 months ago (2016-07-28 03:30:46 UTC) #4
Ben Goodger (Google)
4 years, 4 months ago (2016-07-28 03:33:15 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698