Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2188763003: Set correct token position in moveNext call of for-in loops (fixes #26941). (Closed)

Created:
4 years, 4 months ago by regis
Modified:
4 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set correct token position in moveNext call of for-in loops (fixes #26941). R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/47cf4c187754e63fd02712f677b004251df5728b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/parser.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
4 years, 4 months ago (2016-07-28 01:00:07 UTC) #2
hausner
LGTM. For the record, this is essentially the missing piece of CL https://codereview.chromium.org//577423005.
4 years, 4 months ago (2016-07-28 01:08:52 UTC) #3
regis
On 2016/07/28 01:08:52, hausner wrote: > LGTM. > > For the record, this is essentially ...
4 years, 4 months ago (2016-07-28 01:10:23 UTC) #4
regis
Committed patchset #1 (id:1) manually as 47cf4c187754e63fd02712f677b004251df5728b (presubmit successful).
4 years, 4 months ago (2016-07-28 01:15:26 UTC) #6
regis
4 years, 4 months ago (2016-07-28 15:40:07 UTC) #7
Message was sent while issue was closed.
Matthias,

I suspect this change is not correct, although it fixed the context mismatch
while debugging flutter. I had to disable language/vm/optimized_stacktrace_test
after submitting this change.

If I cannot figure it out shortly, I'll revert it.

Thanks,
Regis

Powered by Google App Engine
This is Rietveld 408576698