Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2188753002: Make Array.prototype[Symbol.iterator] non-constructible. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Array.prototype[Symbol.iterator] non-constructible. R=adamk@chromium.org BUG=v8:5237 Committed: https://crrev.com/d4e5851bad322a39dcf52240e538c16fc47d327e Cr-Commit-Position: refs/heads/master@{#38116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/js/array-iterator.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/es6/array-prototype-values.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 4 months ago (2016-07-27 14:47:17 UTC) #1
adamk
lgtm
4 years, 4 months ago (2016-07-27 20:32:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188753002/1
4 years, 4 months ago (2016-07-28 07:49:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 08:14:04 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 08:20:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e5851bad322a39dcf52240e538c16fc47d327e
Cr-Commit-Position: refs/heads/master@{#38116}

Powered by Google App Engine
This is Rietveld 408576698