[DevTools] add notifyContextDestroyed to V8Inspector

[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
Committed: https://crrev.com/6487a75725fcfa61b963ca8d9abc8e8847fc002a
Cr-Commit-Position: refs/heads/master@{#408443}

[nojvek, 2016-07-28 05:24:51]

nojvek@gmail.com changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-07-28 15:11:17]

Description was changed from

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
==========

to

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
==========

[pfeldman, 2016-07-28 15:11:18]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-07-28 15:12:10]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-07-28 15:12:10]

lgtm

[commit-bot: I haz the power, 2016-07-28 15:12:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:15:30]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nojvek, 2016-07-28 16:44:23]

Trying to make sense why this failed. I don't see anything standing out in logs.

Infra issue ?


On 2016/07/28 15:15:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
>   cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dgozman, 2016-07-28 17:00:57]

On 2016/07/28 16:44:23, nojvek wrote:
> Trying to make sense why this failed. I don't see anything standing out in
logs.
> 
> Infra issue ?

Looks like it.

[pfeldman, 2016-07-28 17:09:09]

if that is your first change, you have to add yourself into the AUTHORS file as
a part of this change. see chromium contributors guide for that.

[nojvek, 2016-07-28 17:27:41]

I'm already in AUTHORS

https://chromium.googlesource.com/chromium/src/+/master/AUTHORS

Let me know if any more changes from my side are needed.

Regards.



On Thu, Jul 28, 2016 at 10:09 AM, <pfeldman@chromium.org> wrote:

> if that is your first change, you have to add yourself into the AUTHORS
> file as
> a part of this change. see chromium contributors guide for that.
>
> https://codereview.chromium.org/2188723004/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[nojvek, 2016-07-28 17:27:41]

I'm already in AUTHORS

https://chromium.googlesource.com/chromium/src/+/master/AUTHORS

Let me know if any more changes from my side are needed.

Regards.



On Thu, Jul 28, 2016 at 10:09 AM, <pfeldman@chromium.org> wrote:

> if that is your first change, you have to add yourself into the AUTHORS
> file as
> a part of this change. see chromium contributors guide for that.
>
> https://codereview.chromium.org/2188723004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[pfeldman, 2016-07-28 17:44:50]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:45:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:48:49]

Description was changed from

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
==========

to

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
==========

[commit-bot: I haz the power, 2016-07-28 18:48:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-28 18:51:23]

Description was changed from

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245
==========

to

==========
[DevTools] add notifyContextDestroyed to V8Inspector

BUG=632245

Committed: https://crrev.com/6487a75725fcfa61b963ca8d9abc8e8847fc002a
Cr-Commit-Position: refs/heads/master@{#408443}
==========

[commit-bot: I haz the power, 2016-07-28 18:51:24]

Patchset 1 (id:??) landed as
https://crrev.com/6487a75725fcfa61b963ca8d9abc8e8847fc002a
Cr-Commit-Position: refs/heads/master@{#408443}