🛀 Fix ApplicationStatus.isEveryActivityDestroyed() = false within callback

chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
@@ skipping 316 matching lines @@
                     "Tab.TotalTabCount.BeforeLeavingApp", totalTabCount);
         }
     }
 
     /**
      * Called after onForegroundSessionEnd() indicating that the activity whose onStop() ended the
      * last foreground session was destroyed.
      */
     private void onForegroundActivityDestroyed() {
         if (ApplicationStatus.isEveryActivityDestroyed()) {
+            // These will all be re-initialized when a new Activity starts / upon next use.
             mBackgroundProcessing.onDestroy();
-            if (mDevToolsServer != null) {

[gone, 2016/07/28 16:09:57]

Why'd these lines get taken out?

[agrieve, 2016/07/28 16:39:27]

I mentioned it in the bug, but have now updated the CL description.

-                mDevToolsServer.destroy();
-                mDevToolsServer = null;
-            }
-            stopApplicationActivityTracker();
             PartnerBrowserCustomizations.destroy();
             ShareHelper.clearSharedImages(this);
-            CombinedPolicyProvider.get().destroy();
         }
     }
 
     private ApplicationStateListener createApplicationStateListener() {
         return new ApplicationStateListener() {
             @Override
             public void onApplicationStateChange(int newState) {
                 if (newState == ApplicationState.HAS_STOPPED_ACTIVITIES) {
                     onForegroundSessionEnd();
                 } else if (newState == ApplicationState.HAS_DESTROYED_ACTIVITIES) {
@@ skipping 506 matching lines @@
      * Caches flags that are needed by Activities that launch before the native library is loaded
      * and stores them in SharedPreferences. Because this function is called during launch after the
      * library has loaded, they won't affect the next launch until Chrome is restarted.
      */
     private void cacheNativeFlags() {
         if (sIsFinishedCachingNativeFlags) return;
         FeatureUtilities.cacheNativeFlags(this);
         sIsFinishedCachingNativeFlags = true;
     }
 }