[heap] Prepare Heap::CopyFixedArrayWithMap for black allocation

[heap] Prepare Heap::CopyFixedArrayWithMap for black allocation

With black allocation turned on we have no guarantee that the target array is
white and will be visited by the marker. Only execute the fast path when we are
allowed to skip the barrier.

R=hpayer@chromium.org
BUG=

Committed: https://crrev.com/1d2a1dd6bf0a2b16639e08c7908608d209e3932d
Cr-Commit-Position: refs/heads/master@{#38142}

[Hannes Payer (out of office), 2016-07-28 15:30:53]

https://codereview.chromium.org/2188713004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2188713004/diff/1/src/heap/heap.cc#newcode3831
src/heap/heap.cc:3831: if (InNewSpace(obj) && (mode == SKIP_WRITE_BARRIER)) {
You can skip the new space check, since GetWriteBarrierMode checks that already.

[Michael Lippautz, 2016-07-28 15:32:27]

https://codereview.chromium.org/2188713004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2188713004/diff/1/src/heap/heap.cc#newcode3831
src/heap/heap.cc:3831: if (InNewSpace(obj) && (mode == SKIP_WRITE_BARRIER)) {
On 2016/07/28 15:30:53, Hannes Payer wrote:
> You can skip the new space check, since GetWriteBarrierMode checks that
already.

Done.

[Michael Lippautz, 2016-07-28 15:34:18]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 15:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 15:55:13]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-07-28 16:09:33]

lgtm

[Michael Lippautz, 2016-07-28 16:17:38]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-07-28 16:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 16:19:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 16:20:44]

Description was changed from

==========
[heap] Prepare Heap::CopyFixedArrayWithMap for black allocation

With black allocation turned on we have no guarantee that the target array is
white and will be visited by the marker. Only execute the fast path when we are
allowed to skip the barrier.

R=hpayer@chromium.org
BUG=
==========

to

==========
[heap] Prepare Heap::CopyFixedArrayWithMap for black allocation

With black allocation turned on we have no guarantee that the target array is
white and will be visited by the marker. Only execute the fast path when we are
allowed to skip the barrier.

R=hpayer@chromium.org
BUG=

Committed: https://crrev.com/1d2a1dd6bf0a2b16639e08c7908608d209e3932d
Cr-Commit-Position: refs/heads/master@{#38142}
==========

[commit-bot: I haz the power, 2016-07-28 16:20:45]

Patchset 2 (id:??) landed as
https://crrev.com/1d2a1dd6bf0a2b16639e08c7908608d209e3932d
Cr-Commit-Position: refs/heads/master@{#38142}