Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 2188713002: [runtime] Fix stack frame iteration in test methods. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Fix stack frame iteration in test methods. R=bmeurer@chromium.org Committed: https://crrev.com/5c1c023b63be8d78025fa8ccbe13b51f2d86d3db Cr-Commit-Position: refs/heads/master@{#38164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M src/runtime/runtime-test.cc View 4 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
The stack iteration was overly verbose and would have ended in an endless loop of ...
4 years, 4 months ago (2016-07-27 10:54:36 UTC) #1
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-07-29 08:35:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188713002/1
4 years, 4 months ago (2016-07-29 09:04:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 09:26:43 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 09:27:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1c023b63be8d78025fa8ccbe13b51f2d86d3db
Cr-Commit-Position: refs/heads/master@{#38164}

Powered by Google App Engine
This is Rietveld 408576698