Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2188703002: Remove layout tests only for grammar checking (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove layout tests only for grammar checking Blink does not have grammar checking, so the following layout tests for grammar checking are removed: editing/spelling/grammar-edit-word.html editing/spelling/grammar-markers-hidpi.html editing/spelling/grammar.html editing/spelling/grammar-paste.html editing/spelling/grammar-markers.html BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/32de271fb02024450856b9a5dcfbe42609739224 Cr-Commit-Position: refs/heads/master@{#408314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -376 lines) Patch
D third_party/WebKit/LayoutTests/editing/spelling/grammar.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html View 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL. There are some other layout tests for both spell and grammar checking. They will ...
4 years, 4 months ago (2016-07-27 10:17:09 UTC) #4
yosin_UTC9
lgtm
4 years, 4 months ago (2016-07-28 02:03:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188703002/1
4 years, 4 months ago (2016-07-28 02:03:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 02:17:34 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 02:20:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32de271fb02024450856b9a5dcfbe42609739224
Cr-Commit-Position: refs/heads/master@{#408314}

Powered by Google App Engine
This is Rietveld 408576698