Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188693002: [gn] Switch some sanitizers to gn

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch some sanitizers to gn This switches asan and tsan. V8 also shares the sanitizer configurations with chromium, but not the required blacklist files. This CL adds empty v8-side files. BUG=chromium:474921

Patch Set 1 #

Patch Set 2 : [gn] Switch most sanitizers to gn #

Patch Set 3 : Blacklist files #

Patch Set 4 : Keep msan #

Patch Set 5 : Rebase #

Patch Set 6 : Keep mac asan #

Patch Set 7 : Splitt of CL #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M infra/mb/mb_config.pyl View 1 2 3 4 5 6 7 7 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2190543003/ needs to land first, as it blocks custom libc++ with GN http://crbug.com/631979 for ...
4 years, 4 months ago (2016-07-27 15:00:13 UTC) #4
Michael Achenbach
FYI comparison links: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/13900/steps/compare%20build%20flags%20%28fyi%29/logs/stdio https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10866/steps/compare%20build%20flags%20%28fyi%29/logs/stdio
4 years, 4 months ago (2016-07-27 15:02:56 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-29 09:42:34 UTC) #8
Michael Achenbach
4 years, 4 months ago (2016-07-29 10:18:38 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698