Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2188643002: GN: dm (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: dm This builds, links, and runs on Linux. Have not tried Mac. I've tested is_debug={true,false} and is_component_build. It's neat that the component build DM works, but it's also an indication I've missed an essential flag or two... it shouldn't work. :) The GPU backend isn't working yet, but all the software configurations I've tried look good. This fleshes out all the other parts of SkCodec too... I noticed we weren't able to decode gifs or webp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188643002 Committed: https://skia.googlesource.com/skia/+/25c81d4e651b43b8217c365c87d530036529a673

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : wip #

Patch Set 4 : moar #

Patch Set 5 : rebase #

Patch Set 6 : jsoncpp, tighter third_party macro #

Patch Set 7 : builds, links, runs #

Patch Set 8 : build expat #

Patch Set 9 : giflib #

Patch Set 10 : Build webp #

Patch Set 11 : fmt #

Patch Set 12 : pick up SK_BUILD_FOR_... in ProcStats.cpp #

Patch Set 13 : gyp deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -14 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 9 chunks +145 lines, -0 lines 0 comments Download
M dm/DM.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/expat/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/giflib/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/jsoncpp/BUILD.gn View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/libjpeg_turbo/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
A third_party/libwebp/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/third_party.gni View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M third_party/zlib/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M tools/ProcStats.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mtklein_C
4 years, 4 months ago (2016-07-27 20:02:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188643002/220001
4 years, 4 months ago (2016-07-27 20:02:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/10107)
4 years, 4 months ago (2016-07-27 20:05:54 UTC) #9
jcgregorio
lgtm
4 years, 4 months ago (2016-07-27 20:09:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188643002/240001
4 years, 4 months ago (2016-07-27 20:10:14 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:55:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/25c81d4e651b43b8217c365c87d530036529a673

Powered by Google App Engine
This is Rietveld 408576698