Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h

Issue 2188623007: Fix DCHECK when opening two password bubbles one after another. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: overload Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h
diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h
index 7a39b4ca38f7d8c6930ad172d7ec146015f3c4bb..7b98efdaf0816b955db41b3d0632561498d4dc6e 100644
--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h
+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h
@@ -27,6 +27,7 @@ class ManagePasswordsBubbleCocoa {
static void Show(content::WebContents* webContents, bool user_action);
// Closes and deletes the bubble.
+ void Close(bool no_animation);
void Close();
// Sets the location bar icon that should be updated with state changes.
@@ -55,10 +56,6 @@ class ManagePasswordsBubbleCocoa {
// The location bar icon corresponding to the bubble.
ManagePasswordsIcon* icon_;
- // Whether there is currently a close operation taking place. Prevents
- // multiple attempts to close the window.
- bool closing_;
-
// The view controller for the bubble. Weak; owns itself. Must be nilled
// after the bubble is closed.
ManagePasswordsBubbleController* controller_;

Powered by Google App Engine
This is Rietveld 408576698