Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.h

Issue 2188623006: Add pre finalizer to Animation to ensure compositor handles get cleaned up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add bool check Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 class ExceptionState; 55 class ExceptionState;
56 56
57 class CORE_EXPORT Animation final 57 class CORE_EXPORT Animation final
58 : public EventTargetWithInlineData 58 : public EventTargetWithInlineData
59 , public ActiveScriptWrappable 59 , public ActiveScriptWrappable
60 , public ActiveDOMObject 60 , public ActiveDOMObject
61 , public CompositorAnimationDelegate 61 , public CompositorAnimationDelegate
62 , public CompositorAnimationPlayerClient { 62 , public CompositorAnimationPlayerClient {
63 DEFINE_WRAPPERTYPEINFO(); 63 DEFINE_WRAPPERTYPEINFO();
64 USING_GARBAGE_COLLECTED_MIXIN(Animation); 64 USING_GARBAGE_COLLECTED_MIXIN(Animation);
65 USING_PRE_FINALIZER(Animation, dispose);
65 public: 66 public:
66 enum AnimationPlayState { 67 enum AnimationPlayState {
67 Unset, 68 Unset,
68 Idle, 69 Idle,
69 Pending, 70 Pending,
70 Running, 71 Running,
71 Paused, 72 Paused,
72 Finished 73 Finished
73 }; 74 };
74 75
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 }; 296 };
296 297
297 // This mirrors the known compositor state. It is created when a compositor 298 // This mirrors the known compositor state. It is created when a compositor
298 // animation is started. Updated once the start time is known and each time 299 // animation is started. Updated once the start time is known and each time
299 // modifications are pushed to the compositor. 300 // modifications are pushed to the compositor.
300 std::unique_ptr<CompositorState> m_compositorState; 301 std::unique_ptr<CompositorState> m_compositorState;
301 bool m_compositorPending; 302 bool m_compositorPending;
302 int m_compositorGroup; 303 int m_compositorGroup;
303 304
304 std::unique_ptr<CompositorAnimationPlayer> m_compositorPlayer; 305 std::unique_ptr<CompositorAnimationPlayer> m_compositorPlayer;
306 bool m_preFinalizerRegistered;
305 307
306 bool m_currentTimePending; 308 bool m_currentTimePending;
307 bool m_stateIsBeingUpdated; 309 bool m_stateIsBeingUpdated;
308 310
309 bool m_effectSuppressed; 311 bool m_effectSuppressed;
310 }; 312 };
311 313
312 } // namespace blink 314 } // namespace blink
313 315
314 #endif // Animation_h 316 #endif // Animation_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/Animation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698