Issue 2188623004: SkPDF: SkPDFStream takes a unique_ptr

Issue 2188623004: SkPDF: SkPDFStream takes a unique_ptr (Closed)

Created:
4 years, 4 months ago by hal.canary

Modified:
4 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -30 lines)			Patch
M	src/pdf/SkPDFDocument.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFFormXObject.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFStream.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 12 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188623004/1

4 years, 4 months ago (2016-07-27 17:57:56 UTC) #10

commit-bot: I haz the power

4 years, 4 months ago (2016-07-27 18:12:26 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ac0e00dceca10dc7ce30c5be66001bd6960ebf5c