Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2188613002: Changes WindowTreeHostMus to not always StopPropagation (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes WindowTreeHostMus to not always StopPropagation Other code should mark the event as handled/stop-propagation as appropriate. If we always mark as consumed accelerators won't be notified appropriately. BUG=612331 TEST=none R=sadrul@chromium.org Committed: https://crrev.com/dd4636a3c3637df3ec2343f3a3f4b3bb26f074c2 Cr-Commit-Position: refs/heads/master@{#408148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
4 years, 4 months ago (2016-07-26 21:31:50 UTC) #2
sadrul
lgtm
4 years, 4 months ago (2016-07-27 16:22:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188613002/1
4 years, 4 months ago (2016-07-27 16:25:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 16:28:55 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:30:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd4636a3c3637df3ec2343f3a3f4b3bb26f074c2
Cr-Commit-Position: refs/heads/master@{#408148}

Powered by Google App Engine
This is Rietveld 408576698