aw: Fix edge case with destroy before detach

aw: Fix edge case with destroy before detach

Currently if destroy is called before detach, we destroy native side,
but don't actually run through the detach code in java side. Then when
the real detach is called later, it gets skipped because AwContents is
already destroyed, causing java-side leaks.

Just go through detach path in destroy. I don't see how this can break
anything.

BUG=612122
Committed: https://crrev.com/32ef413e5187bfdd43dff6a48531afd35f3e9234
Cr-Commit-Position: refs/heads/master@{#408115}

[boliu, 2016-07-26 20:54:37]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[boliu, 2016-07-26 20:54:37]

ptal

[Tobias Sargeant, 2016-07-27 11:33:08]

On 2016/07/26 20:54:37, boliu wrote:
> ptal

Looks ok (and lgtm if you want to land this), although I wonder what in
onDetachedFromWindow really relies on isDestroyed() being false, other than the
direct nativeOnDetachedFromWindow(). Maybe it would be better to just do the
native work early (as now happens) and then save the java-only work until the
actual detach?

[boliu, 2016-07-27 13:26:57]

On 2016/07/27 11:33:08, Tobias Sargeant wrote:
> On 2016/07/26 20:54:37, boliu wrote:
> > ptal
> 
> Looks ok (and lgtm if you want to land this), although I wonder what in
> onDetachedFromWindow really relies on isDestroyed() being false, other than
the
> direct nativeOnDetachedFromWindow().

Problem is other classes like ContentViewCore do not have if (destroyed)
checkes, ie do not allow methods being called after destroy. So we can't safely
call into them again after we've deleted their native peers.

> Maybe it would be better to just do the
> native work early (as now happens) and then save the java-only work until the
> actual detach?

[boliu, 2016-07-27 13:27:09]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-07-27 13:27:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:03:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 14:04:37]

Description was changed from

==========
aw: Fix edge case with destroy before detach

Currently if destroy is called before detach, we destroy native side,
but don't actually run through the detach code in java side. Then when
the real detach is called later, it gets skipped because AwContents is
already destroyed, causing java-side leaks.

Just go through detach path in destroy. I don't see how this can break
anything.

BUG=612122
==========

to

==========
aw: Fix edge case with destroy before detach

Currently if destroy is called before detach, we destroy native side,
but don't actually run through the detach code in java side. Then when
the real detach is called later, it gets skipped because AwContents is
already destroyed, causing java-side leaks.

Just go through detach path in destroy. I don't see how this can break
anything.

BUG=612122

Committed: https://crrev.com/32ef413e5187bfdd43dff6a48531afd35f3e9234
Cr-Commit-Position: refs/heads/master@{#408115}
==========

[commit-bot: I haz the power, 2016-07-27 14:04:38]

Patchset 2 (id:??) landed as
https://crrev.com/32ef413e5187bfdd43dff6a48531afd35f3e9234
Cr-Commit-Position: refs/heads/master@{#408115}