Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2188563002: Issue 26748. Apply existing import/export elements to corresponding directive nodes in DirectiveRes… (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26748. Apply existing import/export elements to corresponding directive nodes in DirectiveResolver using just offsets. If the source was not changes, then AST and elements correspond to each other, otherwise both should have been invalidated. As it is now, it seems that checking creates more problems than it solves. R=brianwilkerson@google.com, pquitslund@google.com BUG= https://github.com/dart-lang/sdk/issues/26748 Committed: https://github.com/dart-lang/sdk/commit/41ac4308879a6a900b19cc216af2e44045eadf9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -110 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +19 lines, -110 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-07-26 20:16:45 UTC) #1
pquitslund
LGTM but would defer to Brian to look at it more substantially.
4 years, 4 months ago (2016-07-26 21:45:27 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-07-27 14:58:14 UTC) #3
scheglov
4 years, 4 months ago (2016-07-27 15:35:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41ac4308879a6a900b19cc216af2e44045eadf9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698