Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188523005: Remove ScreenOrientation runtime flag (status=stable) (Closed)

Created:
4 years, 4 months ago by rwlbuis
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScreenOrientation runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/fbcc7784f1b162ff41d2b6e7678899e64c8c7f62 Cr-Commit-Position: refs/heads/master@{#408762}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenScreenOrientation.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
rwlbuis
PTAL.
4 years, 4 months ago (2016-07-28 14:34:36 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 4 months ago (2016-07-28 19:28:07 UTC) #4
rwlbuis
@eae PTAL
4 years, 4 months ago (2016-07-28 20:36:22 UTC) #6
eae
LGTM
4 years, 4 months ago (2016-07-29 17:31:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188523005/20001
4 years, 4 months ago (2016-07-29 17:32:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/227836)
4 years, 4 months ago (2016-07-29 17:37:43 UTC) #11
rwlbuis
Adding haraken for web.
4 years, 4 months ago (2016-07-29 18:03:05 UTC) #13
haraken
On 2016/07/29 18:03:05, rwlbuis wrote: > Adding haraken for web. LGTM
4 years, 4 months ago (2016-07-29 18:27:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188523005/20001
4 years, 4 months ago (2016-07-29 19:10:56 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 21:22:59 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:24:44 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fbcc7784f1b162ff41d2b6e7678899e64c8c7f62
Cr-Commit-Position: refs/heads/master@{#408762}

Powered by Google App Engine
This is Rietveld 408576698