Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2188523002: Revert of Remove pageview from map immediately (Closed)

Created:
2 years, 7 months ago by dsinclair
Modified:
2 years, 7 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove pageview from map immediately (patchset #1 id:1 of https://codereview.chromium.org/2179283005/ ) Reason for revert: Looks like this broke linux_asan embedder tests. https://build.chromium.org/p/client.pdfium/builders/linux_asan/builds/1152/steps/embeddertests/logs/stdio Original issue's description: > Remove pageview from map immediately > > There seems to be an ownership issue in the page annotation code where removing > the annotations can result in removing the parent page view. This is fine except > that removing the parent page view removes the annotations and you can end up > with a use-after-free. > > This CL removes the page view from the documents page map immediately and then > proceeds with the cleanup. Then, if we try to remove that page again it won't > be found and we won't double free. > > BUG=chromium:630654 > > Committed: https://pdfium.googlesource.com/pdfium/+/49dce65dc78bcd5a0c78a8bbdf2809cf20212220 TBR=thestig@chromium.org,weili@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630654 Committed: https://pdfium.googlesource.com/pdfium/+/f2cee9894b9f7cf2e50060965ad1eedd90ab55b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Remove pageview from map immediately
2 years, 7 months ago (2016-07-26 19:19:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188523002/1
2 years, 7 months ago (2016-07-26 19:19:39 UTC) #3
commit-bot: I haz the power
2 years, 7 months ago (2016-07-26 19:19:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f2cee9894b9f7cf2e50060965ad1eedd90ab...

Powered by Google App Engine
This is Rietveld 408576698