Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 21885003: Enables unboxed mints in ia32 javascript int compatability mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 25734)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -2152,13 +2152,14 @@
static void EmitJavascriptOverflowCheck(FlowGraphCompiler* compiler,
+ Range* range,
Label* overflow,
Register result) {
- if (FLAG_throw_on_javascript_int_overflow) {
+ if (!range->IsWithin(-0x20000000000000LL, 0x20000000000000LL)) {
ASSERT(overflow != NULL);
- __ cmpq(result, Immediate(-0x20000000000000));
+ __ cmpq(result, Immediate(-0x20000000000000LL));
__ j(LESS, overflow);
- __ cmpq(result, Immediate(0x20000000000000));
+ __ cmpq(result, Immediate(0x20000000000000LL));
__ j(GREATER, overflow);
}
}
@@ -2203,7 +2204,9 @@
// Shift for result now we know there is no overflow.
__ shlq(left, Immediate(value));
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, shift_left->range(), deopt, result);
+ }
return;
}
@@ -2233,7 +2236,9 @@
__ SmiUntag(right);
__ shlq(left, right);
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, shift_left->range(), deopt, result);
+ }
return;
}
@@ -2284,7 +2289,9 @@
// Shift for result now we know there is no overflow.
__ shlq(left, right);
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, shift_left->range(), deopt, result);
+ }
}
@@ -2483,7 +2490,9 @@
UNREACHABLE();
break;
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), deopt, result);
+ }
return;
} // locs()->in(1).IsConstant().
@@ -2526,7 +2535,9 @@
UNREACHABLE();
break;
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), deopt, result);
+ }
return;
} // locs()->in(1).IsStackSlot().
@@ -2656,7 +2667,9 @@
UNREACHABLE();
break;
}
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), deopt, result);
+ }
}
@@ -3834,7 +3847,9 @@
kDeoptUnaryOp);
__ negq(value);
__ j(OVERFLOW, deopt);
- EmitJavascriptOverflowCheck(compiler, deopt, value);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), deopt, value);
+ }
break;
}
case Token::kBIT_NOT:
@@ -3895,7 +3910,9 @@
__ shlq(temp, Immediate(1));
__ j(OVERFLOW, &do_call, Assembler::kNearJump);
__ SmiTag(result);
- EmitJavascriptOverflowCheck(compiler, &do_call, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), &do_call, result);
+ }
__ jmp(&done);
__ Bind(&do_call);
ASSERT(instance_call()->HasICData());
@@ -3941,7 +3958,9 @@
__ shlq(temp, Immediate(1));
__ j(OVERFLOW, deopt);
__ SmiTag(result);
- EmitJavascriptOverflowCheck(compiler, deopt, result);
+ if (FLAG_throw_on_javascript_int_overflow) {
+ EmitJavascriptOverflowCheck(compiler, range(), deopt, result);
+ }
}
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698