runtime/vm/intermediate_language.cc - Issue 21885003: Enables unboxed mints in ia32 javascript int compatability mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 21885003: Enables unboxed mints in ia32 javascript int compatability mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 25734)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -1076,7 +1076,11 @@

bool BinarySmiOpInstr::CanDeoptimize() const {

- if (FLAG_throw_on_javascript_int_overflow) return true;

+ if (FLAG_throw_on_javascript_int_overflow && (Smi::kBits > 32)) {

+ // If Smi's are bigger than 32-bits, then the instruction could deoptimize

+ // if the result is too big.

+ return true;

+ }

switch (op_kind()) {

case Token::kBIT_AND:

case Token::kBIT_OR:

« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »