Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2188493002: Start on fiddle. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : year #

Patch Set 3 : now with codec #

Total comments: 2

Patch Set 4 : simpler blacklist logic #

Patch Set 5 : fiddle is a better example than example #

Patch Set 6 : update blacklist #

Patch Set 7 : Only run recipe simulation tests if infra/ changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -21 lines) Patch
M BUILD.gn View 1 2 3 4 5 chunks +56 lines, -21 lines 0 comments Download
M PRESUBMIT.py View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A gn/echo_headers.py View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mtklein
Was just reading through Joe's work-in-progress CL and made a few tweaks as a typed ...
4 years, 4 months ago (2016-07-26 18:01:03 UTC) #3
jcgregorio
lgtm
4 years, 4 months ago (2016-07-26 18:33:24 UTC) #4
mtklein_C
Please take another look at PS3, which adds enough Codec to get fiddle running.
4 years, 4 months ago (2016-07-26 18:52:43 UTC) #5
hal.canary
https://codereview.chromium.org/2188493002/diff/40001/gn/echo_headers.py File gn/echo_headers.py (right): https://codereview.chromium.org/2188493002/diff/40001/gn/echo_headers.py#newcode26 gn/echo_headers.py:26: skip = False for h in headers: if h ...
4 years, 4 months ago (2016-07-26 18:54:09 UTC) #6
mtklein
https://codereview.chromium.org/2188493002/diff/40001/gn/echo_headers.py File gn/echo_headers.py (right): https://codereview.chromium.org/2188493002/diff/40001/gn/echo_headers.py#newcode26 gn/echo_headers.py:26: skip = False On 2016/07/26 18:54:09, Hal Canary wrote: ...
4 years, 4 months ago (2016-07-26 18:55:41 UTC) #7
hal.canary
lgtm
4 years, 4 months ago (2016-07-26 19:11:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188493002/80001
4 years, 4 months ago (2016-07-26 19:14:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188493002/100001
4 years, 4 months ago (2016-07-26 20:19:27 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:55:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/1211e0ca74fc4b58dd314c87e94692b4d61be9b7

Powered by Google App Engine
This is Rietveld 408576698