Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2188483008: PPC/s390: [stubs] Port CreateWeakCellStub to turbofan (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Port CreateWeakCellStub to turbofan Port 7f1fa30e3437d38ab7c949c19659f52e8233fba9 Original commit message: In the process also inline the stub into the appropriate interpreter bytecode handler and make sure that the context register is preserved in hand-written assembly code that calls the stub and expects the context register to be preserved. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=608675 LOG=N Committed: https://crrev.com/ddea5a67853f725a0c7cdb4b85a7b63445eaa5d4 Cr-Commit-Position: refs/heads/master@{#38148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
john.yan
lgtm
4 years, 4 months ago (2016-07-28 19:00:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188483008/1
4 years, 4 months ago (2016-07-28 19:03:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 19:26:37 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 19:29:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddea5a67853f725a0c7cdb4b85a7b63445eaa5d4
Cr-Commit-Position: refs/heads/master@{#38148}

Powered by Google App Engine
This is Rietveld 408576698