Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2188483007: Revert of align cap hairline first point (Closed)

Created:
4 years, 4 months ago by tomhudson
Modified:
4 years, 4 months ago
Reviewers:
f(malita), caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of align cap hairline first point (patchset #2 id:20001 of https://codereview.chromium.org/2189583003/ ) Reason for revert: Speculative revert in case this is blocking our roll. Original issue's description: > align cap hairline first point > > Hairlines with square caps move the endpoints out by 1/2 pixel. > The last point needs to be the first adjusted point, instead > of the point supplied to move to. > > R=fmalita@chromium.org > TBR=reed@google.com > BUG=617658 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 > > Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05 TBR=fmalita@chromium.org,reed@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617658 Committed: https://skia.googlesource.com/skia/+/92772222bf548acf937761eb5150d5bb8e4a7bc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/core/SkScan_Hairline.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tomhudson
Created Revert of align cap hairline first point
4 years, 4 months ago (2016-07-28 14:36:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188483007/1
4 years, 4 months ago (2016-07-28 14:36:24 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 14:36:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/92772222bf548acf937761eb5150d5bb8e4a7bc4

Powered by Google App Engine
This is Rietveld 408576698