Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.cpp

Issue 2188483004: Remove extraneous frameView->setNeedsLayout() in LayoutPart (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove bogus test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutPart.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.cpp b/third_party/WebKit/Source/core/layout/LayoutPart.cpp
index e231eb5d41170c99d1a1db0da80b9405466c43cf..1cee9533bd563e070ba5b7a5e76abb9fda05e5a1 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.cpp
@@ -297,22 +297,12 @@ void LayoutPart::updateWidgetGeometry()
if (!widget || !node()) // Check the node in case destroy() has been called.
return;
- IntRect newFrame = roundedIntRect(contentBoxRect());
- bool boundsWillChange = widget->frameRect().size() != newFrame.size();
-
- FrameView* frameView = widget->isFrameView() ? toFrameView(widget) : nullptr;
-
- // If frame bounds are changing mark the view for layout. Also check the
- // frame's page to make sure that the frame isn't in the process of being
- // destroyed.
- if (frameView && boundsWillChange && frameView->frame().page())
- frameView->setNeedsLayout();
-
updateWidgetGeometryInternal();
// If view needs layout, either because bounds have changed or possibly
// indicating content size is wrong, we have to do a layout to set the right
// widget size.
+ FrameView* frameView = widget->isFrameView() ? toFrameView(widget) : nullptr;
if (frameView && frameView->needsLayout() && frameView->frame().page())
frameView->layout();

Powered by Google App Engine
This is Rietveld 408576698