Remove extraneous frameView->setNeedsLayout() in LayoutPart

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Text.h"
@@ skipping 77 matching lines @@
     EXPECT_FALSE(selection().isCaretBoundsDirty());
 
     document().body()->removeChild(text);
     document().updateStyleAndLayoutIgnorePendingStylesheets();
     selection().setCaretRectNeedsUpdate();
     EXPECT_TRUE(selection().isCaretBoundsDirty());
     selection().invalidateCaretRect();
     EXPECT_FALSE(selection().isCaretBoundsDirty());
 }
 
-TEST_F(FrameSelectionTest, PaintCaretShouldNotLayout)
-{
-    Text* text = appendTextNode("Hello, World!");
-    document().view()->updateAllLifecyclePhases();
-
-    document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
-    document().body()->focus();
-    EXPECT_TRUE(document().body()->focused());
-
-    VisibleSelection validSelection(Position(text, 0), Position(text, 0));
-    selection().setCaretVisible(true);
-    setSelection(validSelection);
-    EXPECT_TRUE(selection().isCaret());
-    EXPECT_TRUE(shouldPaintCaretForTesting());
-
-    int startCount = layoutCount();
-    {
-        // To force layout in next updateLayout calling, widen view.
-        FrameView& frameView = dummyPageHolder().frameView();
-        IntRect frameRect = frameView.frameRect();
-        frameRect.setWidth(frameRect.width() + 1);
-        frameRect.setHeight(frameRect.height() + 1);
-        dummyPageHolder().frameView().setFrameRect(frameRect);
-    }
-    std::unique_ptr<PaintController> paintController = PaintController::create();
-    {
-        GraphicsContext context(*paintController);
-        DrawingRecorder drawingRecorder(context, *dummyPageHolder().frameView().layoutView(), DisplayItem::Caret, LayoutRect::infiniteIntRect());
-        selection().paintCaret(context, LayoutPoint());
-    }
-    paintController->commitNewDisplayItems();
-    EXPECT_EQ(startCount, layoutCount());

[trchen, 2016/07/28 00:04:36]

This is bogus. Resizing the frame would invalidate layout, and painting requires
a clean layout. It is wrong to expect layoutCount() not increased.

The original CL that introduced this test to make sure caret painting code is
impossible to invoke layout, but I think the method in that CL was wrong. We
should have figured out why layout could be dirty during paint.

[bokan, 2016/07/28 13:24:56]

Agree, this is sketchy. Could you file a bug to follow up with your suggestion
of figuring out why layout can be dirty during paint?

[trchen, 2016/07/28 22:45:54]

I think the original bug is already solved. Xianzhu recently invested a lot of
time to investigate layout lifecycle bugs. We now have many more DCHECK and
fixed them. Here is the meta bug: crbug.com/590856

[bokan, 2016/07/28 22:48:41]

ok, sgtm, thanks.

-}
-
 TEST_F(FrameSelectionTest, InvalidatePreviousCaretAfterRemovingLastCharacter)
 {
     Text* text = appendTextNode("Hello, World!");
     document().view()->updateAllLifecyclePhases();
 
     document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
     document().body()->focus();
     EXPECT_TRUE(document().body()->focused());
 
     selection().setCaretVisible(true);
@@ skipping 153 matching lines @@
     selection().updateIfNeeded();
 
     // TODO(yosin): Once lazy canonicalization implemented, selection.start
     // should be Position(HTML, 0).
     EXPECT_EQ(Position(), selection().start())
         << "updateIfNeeded() makes selection to null.";
     EXPECT_EQ(selection().start(), caretPosition().position());
 }
 
 } // namespace blink