Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/shell/BUILD.gn

Issue 2188473002: [Mac/GN] Configure ASan for bundled targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index bb5eac67f30a361c146e554d42931974bc01c88e..b3a9ec2c4eb5f96db1ef9bcec950e5538236687f 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -482,6 +482,10 @@ if (is_android) {
"@executable_path/../",
]
info_plist_target = ":content_shell_plist"
+
+ if (using_sanitizer) {
+ ldflags += [ "-Wcrl,installname,@executable_path/$asan_runtime_basename,@rpath/$asan_runtime_basename" ]
+ }
}
} else {
# TODO(brettw) when GYP is no longer necessary, delete
@@ -681,6 +685,10 @@ if (is_mac) {
]
}
+ if (using_sanitizer) {
+ ldflags += [ "-Wcrl,installname,@executable_path/$asan_runtime_basename,@rpath/$asan_runtime_basename" ]
+ }
+
info_plist_target = ":content_shell_framework_plist"
}
@@ -712,6 +720,10 @@ if (is_mac) {
"@executable_path/../../../..",
]
info_plist_target = ":content_shell_helper_plist"
+
+ if (using_sanitizer) {
+ ldflags += [ "-Wcrl,installname,@executable_path/$asan_runtime_basename,@rpath/$asan_runtime_basename" ]
+ }
}
bundle_data("content_shell_framework_bundle_data") {
@@ -727,6 +739,11 @@ if (is_mac) {
":content_shell_framework+link",
":content_shell_helper_app",
]
+
+ if (using_sanitizer) {
+ sources += [ "$root_out_dir/$asan_runtime_basename" ]
+ public_deps += [ "//build/config/sanitizers:copy_asan_runtime" ]
+ }
}
bundle_data("content_shell_resources_bundle_data") {
« no previous file with comments | « chrome/BUILD.gn ('k') | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698