third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js - Issue 2188413004: DevTools: Remove Advanced heap snapshot properties setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

Issue 2188413004: DevTools: Remove Advanced heap snapshot properties setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js ('K') | « third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

index a0bfb995271617156d59194599ae7b13304822f6..df3724a069603ba747ecce2f8b74a3bd91622d91 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

@@ -297,8 +297,7 @@ WebInspector.HeapSnapshotLoaderProxy.prototype = {

{

if (callback)

callback();

- var showHiddenData = WebInspector.moduleSetting("showAdvancedHeapSnapshotProperties").get();

- this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy, showHiddenData);

+ this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy);

}

/**